Skip to content

fix (installpsh-mariner.sh): add a case for azure linux #25369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix (installpsh-mariner.sh): add a case for azure linux #25369

wants to merge 1 commit into from

Conversation

nanma321
Copy link

@nanma321 nanma321 commented Apr 16, 2025 •
edited
Loading

PR Summary

This PR is to add a case in powershell install script for Mariner to include a case for Azure Linux. Previsously, there is an PR #23955 to fix it in the main script. However, the same case needs to be added in the installpsh-mariner.sh for it to fully work.

PR Checklist

I tested with Azure Linux image and the change works

@nanma321 nanma321 requested a review from a team as a code owner April 16, 2025 20:55
@nanma321 nanma321 mentioned this pull request Apr 16, 2025
Open
5 tasks
TravisEz13
TravisEz13 requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be ported to GitHub workflows.

It would be better if these were in their own repo.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 16, 2025
@nanma321
Copy link
Author

Tests need to be ported to GitHub workflows.

It would be better if these were in their own repo.

@TravisEz13 is there existing github workflows in Powershell repo to test this script? What I did was just to deploy the azure linux image and run the script with and without the change to validate

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 17, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Review - Needed The PR is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanma321 @TravisEz13
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy