-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Move MSIXBundle to Packages and Release to GitHub #25512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
May 6, 2025
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
May 6, 2025
9 tasks
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
May 6, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport-7.4.x-Migrated
Backport-7.5.x-Migrated
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces changes to the Azure DevOps pipeline configurations to streamline the handling of MSIX bundles. The updates include adding a new MSIX bundle creation stage, integrating its artifacts into the upload process, and refactoring the MSIX-related logic for better reusability and clarity.
Pipeline Updates for MSIX Bundles:
msixbundle
stage was added to thePowerShell-Packages-Official.yml
pipeline, which depends on thewindows_package
stage and uses the newly createdpackage-create-msix.yml
template. This ensures MSIX bundles are generated as part of the build process. ([.pipelines/PowerShell-Packages-Official.ymlR250-R257](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-94820840eb18ab110a6244f06a5d156e757c980ceebcfe03a4f2591bb67bc859R250-R257)
)upload
stage in thePowerShell-Packages-Official.yml
pipeline now depends on themsixbundle
stage, ensuring that MSIX artifacts are included in the final upload process. ([.pipelines/PowerShell-Packages-Official.ymlR250-R257](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-94820840eb18ab110a6244f06a5d156e757c980ceebcfe03a4f2591bb67bc859R250-R257)
)Refactoring and Template Improvements:
release-create-msix.yml
template was renamed topackage-create-msix.yml
and updated to useDownloadPipelineArtifact@2
tasks for downloading artifacts. This improves clarity and aligns with standard practices. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL16-R41)
,[[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL56-R68)
)Build.ArtifactStagingDirectory
) for downloads and processing, replacing hardcoded paths. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL56-R68)
,[[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL90-L129)
)Removal of MSIX Logic from Release Pipeline:
msixbundle
stage was removed from thePowerShell-Release-Official.yml
pipeline, as its functionality has been consolidated into thePowerShell-Packages-Official.yml
pipeline. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b25fb4a8cfad5e36ba1c9c9c7cbe494fce4eed0067878610ebb12ffcab7e41cdL125-L130)
,[[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b25fb4a8cfad5e36ba1c9c9c7cbe494fce4eed0067878610ebb12ffcab7e41cdL273)
)Enhancements to Upload Logic:
uploadToAzure.yml
: Added logic to upload MSIX bundles to Azure Blob Storage, including handling for existing blobs to avoid duplication. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-198718b336446a8a528c995da4f1bc5edf20c0ba40ea06852fece3512c67e0c9R237-R245)
,[[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-198718b336446a8a528c995da4f1bc5edf20c0ba40ea06852fece3512c67e0c9R412-R434)
)PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright header