Skip to content

Make the interface IDeepCloneable internal #25552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the interface IDeepCloneable internal #25552

wants to merge 2 commits into from

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 13, 2025 •
edited
Loading

PR Summary

This PR is a follow-up of the #25497.
The deep clone support in Microsoft.Management.UI.Internal should be made an implementation detail, so make the IDeepCloneable interface internal instead.

PR Checklist

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned daxian-dbw May 13, 2025
@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log and removed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels May 13, 2025
@daxian-dbw
Copy link
Member Author

@mawosoft please let me know if you any concerns.

@mawosoft
Copy link
Contributor

@daxian-dbw I don't have any concerns, it's just odd to pick one among many. None of these classes should probably be public.

Also, nit: If you make it internal, you can remove the suppression attribute.

@daxian-dbw
Copy link
Member Author

The suppression attribute is removed. The main reason to make the IDeepCloneable interface internal is to rule out the possibility that someone may implement this interface and feed such an object to Out-GridView to break the clone in any unexpected way.

@daxian-dbw daxian-dbw requested a review from TravisEz13 May 13, 2025 19:51
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label May 21, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BackPort-7.5.x-Consider CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Review - Needed The PR is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxian-dbw @mawosoft @iSazonov
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy