Skip to content

Add numpy utilities and game data pre-processing #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2020
Merged

Add numpy utilities and game data pre-processing #36

merged 6 commits into from
Feb 14, 2020

Conversation

ViliamVadocz
Copy link
Contributor

The utilities should be well documented and easy to use.

@tarehart
Copy link
Contributor

I like the idea of providing these utils for people who prefer to work with numpy. I'm concerned that it currently clashes with the rest of bot.py though because it's using the Vec3 class everywhere else.

Would you be willing to change this so it's just np_data.py and np_utils.py, and leave bot.py alone to avoid confusing anyone? Or in bot.py you could just have a comment like "Do you prefer to work with numpy? If so, you can find some utils in [folder]"

@ViliamVadocz
Copy link
Contributor Author

Good point, although if we plan to use RLU there will be clashes anyway. I moved the utilities to a separate folder and removed the example code from bot.py.

@tarehart
Copy link
Contributor

Great, thank you! Could you also remove the commented out code and make function names like a3v more descriptive?

For RLU was thinking of making a nice little wrapper function for aerials that takes Vec3 args

@ViliamVadocz
Copy link
Contributor Author

a3l, a3v, and a3r are meant to be shorthand for converting other object types to numpy arrays. Although with good auto-complete suggestions it doesn't take much longer to write.

The commented out code is there so that you don't process things you don't use. If you do decide to use it you don't have to do any more work; just uncomment.

@tarehart tarehart merged commit 935acd8 into RLBot:spikesprint Feb 14, 2020
@tarehart
Copy link
Contributor

Looks good, thanks Will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy