Skip to content

chore: add ruff format --check #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

chore: add ruff format --check #5774

merged 2 commits into from
May 12, 2025

Conversation

rexledesma
Copy link
Contributor

@rexledesma rexledesma commented May 8, 2025 •
edited
Loading

Depends on #5773.

Summary

Add a ruff format step for the Python files generated by contributors.

Main file to look at here is 4f14a31#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd.

Note that we ignore formating syntax_*.py and badsyntax_*.py files as they are specifically testing non standardized code formating.

Test Plan

RustPython on  rl/add-ruff-format via 🐍 v3.13.2 via 🦀 v1.86.0 
❯ uvx --from "ruff==0.11.8" ruff format --check
217 files already formatted

@rexledesma rexledesma force-pushed the rl/add-ruff-format branch from 3e55eef to 4f14a31 Compare May 8, 2025 04:38
@rexledesma rexledesma mentioned this pull request May 8, 2025
Merged
@rexledesma rexledesma force-pushed the rl/add-ruff-format branch from 4f14a31 to 6f0b586 Compare May 8, 2025 12:24
@rexledesma rexledesma force-pushed the rl/add-ruff-format branch from 6f0b586 to 9d8c46a Compare May 11, 2025 14:50
youknowone
youknowone approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youknowone youknowone merged commit 4e2e0b4 into RustPython:main May 12, 2025
11 checks passed
hbina pushed a commit to hbina/RustPython that referenced this pull request May 14, 2025
@rexledesma @hbina
chore: add ruff format --check (RustPython#5774)
17fd1b9 
* chore: add `ruff format --check`

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arihant2math arihant2math arihant2math left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexledesma @youknowone @arihant2math
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy