-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Fix video uploader secrets pass to Node single container #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
CI Feedback 🧐(Feedback updated until commit 6e11b23)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
* K8s: Update list default values for cross-browsers * K8s: Fix video uploader secrets pass to Node single container --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
…umHQ#2886) * K8s: Update list default values for cross-browsers * K8s: Fix video uploader secrets pass to Node single container --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Update browser version lists to include newer versions
Add Chrome/Edge versions 134.0-137.0 to Kubernetes configuration
Add Firefox versions 136.0-139.0 to cross-browser setup
Exclude script generation directory from CI workflow
Changes diagram
Changes walkthrough 📝
__init__.py
Update browser version test lists
tests/SeleniumTests/init.py
LIST_CHROMIUM_VERSIONS
to include versions 131.0-137.0LIST_FIREFOX_VERSIONS
to include versions 133.0-139.0build-test.yml
Exclude script generation from CI workflow
.github/workflows/build-test.yml
scripts/generate_list_env_vars/**
to paths-ignore listmultiple-nodes-platform-version.yaml
Add newer browser versions to K8s chart
charts/selenium-grid/multiple-nodes-platform-version.yaml