Fixes and update Minecarts #8064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
suggested changes
Jul 21, 2025
TheLimeGlass
commented
Jul 21, 2025
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
approved these changes
Jul 22, 2025
1 task
1 task
APickledWalrus
requested changes
Jul 24, 2025
| return false; | ||
| } | ||
| protected boolean equals_i(EntityData<?> obj) { | ||
| return obj instanceof MinecartData minecartData && type == minecartData.type; |
There was a problem hiding this comment.
Suggested change
| return obj instanceof MinecartData minecartData && type == minecartData.type; | |
| return obj instanceof MinecartData minecartData && | |
| isSupertype == minecartData.isSupertype && | |
| type == minecartData.type; |
Ah, perhaps this why the earlier confusion. Need to check superType here to differentiate between minecart and regular minecart
There was a problem hiding this comment.
It doesn't matter, the class types of Minecarts don't have any defining fields. The getSuperType method takes priority in basically all the equals checks.
There was a problem hiding this comment.
Right, but this method should still be correct. regular minecart and minecart should not be considered equal by this method (hence the recommendation of an isSuperType check)
APickledWalrus
requested changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
minecartmaps to the Minecart.class which is an interface... You can't spawn an interface.Solution
Update the MinecartData class with proper handling of the different Minecart classes.
I also moved the
WORLD_1_17_CONSUMERoutside the try catch, because it doesn't need to be doing a try catch every time an entity is spawned.All of these would fail prior to this pull request aside from the spawning of a storage minecart:
Completes: #7663