X11 Media Key Support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm totally fine with hacky solutions for the keycodes... (I mean, just look at the windows code). Generic conversion is fine as long as it works, but the more keys we can support, the better. Thanks for the PR.
That would be awesome! I think the solution is fine, as there is no "universal generic solution" for keycodes. If you can find a solution for windows, that would be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Skycoder,
I know this is not a very elegant solution and is basically a hacky workaround. But I'd really like to see support for media keys, and I don't want to ask without at least providing some sort of solution. XFree86 are extensions to the keysymdef.h file that X11 lib includes, and is shipped with most major distributions. The problem here was that Qt keys don't map (even 1:1) to these, which makes XStringToKeysym() fail. That X method does load the XF86keysym.h file, however so these are valid keys on all OSs that include these definitions.
If you'd be interested in extending support for media keys, I'd be happy to develop and test on X11 and Windows (don't have access to a Mac). I can employ similar solutions if you can't think of a better one, but I'd be happy to discuss better solutions as well. Thanks!