fix include path in CMakeLists.txt #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The include path is not set correctly when QHotkey is build as a subproject. To fix that CMAKE_CURRENT_SOURCE_DIR should be used instead of CMAKE_SOURCE_DIR in target_include_directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include path is not set correctly when QHotkey is build as a
subdirectory. Consider the following project structure:
When this is built,
CMAKE_SOURCE_DIRrefers tomy_project, so the QHotkey header is not found by the targets defined inmy_project/CMakeLists.txt. UsingCMAKE_CURRENT_SOURCE_DIRintarget_include_directoriesshould fix this.