Skip to content

WIP: Labels #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

WIP: Labels #5415

wants to merge 14 commits into from

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Oct 27, 2021

Experimenting with a label changing workflow. Do not merge.
The idea is to adjust the label colors and descriptions in a file that we check into the repo.

Current labels list is an export made with https://github.com/micnncim/label-exporter
Eventually, I'll work on updating the label colors and descriptions.

tests of labels workflow:

@cognifloyd cognifloyd added the WIP label Oct 27, 2021
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Oct 27, 2021
Copy link
Member Author

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armab I'm slowly working through labels and colors to try and come up with some kind of systematic color scheme. All random colors means the colors have no meaning at all. I'm trying to give the colors common meaning.

I started by setting putting in the colors as they are now, and then resetting the standard github labels back to the github standard colors + descriptions. Then, I started grouping the labels and looking for a color to use for each group of labels.

What do you think of the grouping?
What about the colors?

Comment on lines +141 to +147
# ##### area/code_location labels ##### #
- color: 0075ca # blue (standard github)
description: Improvements or additions to documentation
name: documentation
- color: 0075ca # blue
description: ""
name: API
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this color of blue for area/code_location and area/python labels. Here is how #0075ca looks in dark and light mode:
image

Comment on lines +87 to +95
- color: cfd3d7 # gray (standard github)
description: This issue or pull request already exists
name: duplicate # status:duplicate
- color: e4e669 # yellow (standard github)
description: This doesn't seem right
name: invalid # status:invalid
- color: ffffff # white (standard github)
description: This will not be worked on
name: wontfix # status:wontfix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these three labels should have the status: prefix like the rest of the status labels.

Comment on lines +44 to +49
- color: d73a4a # red (standard github)
description: Something isn't working
name: bug
- color: d73a4a
description: ""
name: bug fix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace bug fix with just bug. If it's an issue labeled bug, then it describes a bug. If it's a PR labeled bug then it fixes a bug.

Suggested change
- color: d73a4a # red (standard github)
description: Something isn't working
name: bug
- color: d73a4a
description: ""
name: bug fix
- color: d73a4a # red (standard github)
description: Something isn't working
name: bug

Comment on lines +196 to +199
# ##### area/pack_resources labels ##### #
- color: 003459 # blue
description: ""
name: action aliases
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this color of blue for area/pack_resources labels. Here is how #003459 looks in dark and light mode:
image

Comment on lines +222 to +225
# ##### area/external_services labels ##### #
- color: 8336ff # blue
description: ""
name: database
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this color of purple for area/external_services and area/logging_and_performance labels. Here is how #8336ff looks in dark and light mode:
image

Comment on lines +247 to +250
# ##### area/install labels ##### #
- color: 50209c # purple
description: ""
name: deployment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this color of purple for area/install labels. Here is how #50209c looks in dark and light mode:
image

Comment on lines +270 to +276
# ##### area/security labels ##### #
- color: 63112b # red purple
description: ""
name: RBAC
- color: 63112b # red purple
description: ""
name: security
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I opted for a more red/purple #63112b for the area/security labels.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines. Requires some effort to review. WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy