fix: improve character death parsing and removing creature prefix #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 80.30% 80.29% -0.02%
==========================================
Files 22 22
Lines 3686 3694 +8
==========================================
+ Hits 2960 2966 +6
- Misses 585 587 +2
Partials 141 141 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/TibiaCharactersCharacter.gofile and its associated test filesrc/TibiaCharactersCharacter_test.go. The changes primarily focus on improving string handling, adding new test cases, and updating existing test cases to match the new string handling logic.String Handling Improvements:
unicodeandunicode/utf8to handle string prefixes and character cases. (src/TibiaCharactersCharacter.go)TibiaDataParseKillerfunction to remove prefixes like "and", "a", and "an" from data strings and handle lowercase characters. (src/TibiaCharactersCharacter.go)Test Case Updates:
TestNumber4to remove prefixes like "a" and "an" from creature names in death records. (src/TibiaCharactersCharacter_test.go) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]New Test Cases:
TestNumber15andTestNumber16to validate the new string handling logic with different character data. (src/TibiaCharactersCharacter_test.go)fix #455
fix #439
fix #344
fix #341