-
-
Notifications
You must be signed in to change notification settings - Fork 44
feat: 611 move cores usetexture to cientos #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alvarosabu
merged 13 commits into
next
from
feature/611-move-cores-usetexture-to-cientos
May 18, 2025
Merged
feat: 611 move cores usetexture to cientos #617
alvarosabu
merged 13 commits into
next
from
feature/611-move-cores-usetexture-to-cientos
May 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced the `useTexture` composable for loading textures in TresJS scenes using THREE.js's texture loader. - Created a new demo component `UseTextureDemo.vue` to showcase the usage of the `useTexture` composable. - Updated the documentation to include a guide for `useTexture`, detailing its options and providing usage examples. - Added new routes and components in the playground for testing and demonstrating the `useTexture` functionality. - Ensured all new components follow best practices and TypeScript standards.
- Added the `useTextures` composable for loading multiple textures simultaneously in TresJS scenes using THREE.js's texture loader. - Created a new demo component `PBRTexturesDemo.vue` to showcase the usage of the `useTextures` composable with PBR textures. - Updated the documentation to include a guide for `useTextures`, detailing its parameters, return values, and providing usage examples. - Added new routes and components in the playground for testing and demonstrating the `useTextures` functionality. - Ensured all new components adhere to best practices and TypeScript standards.
…ocumentation - Removed unnecessary console logging of loading state in `PBRTexturesDemo.vue` for cleaner output. - Adjusted formatting in `use-textures.md` for improved readability. - Updated import statements in `PBRTextures.vue` to remove unused dependencies, streamlining the component. - Ensured all changes adhere to TypeScript standards and best practices.
…pment output - Added an ESLint directive to disable console warnings in `PBRTextures.vue`, allowing for a more streamlined development experience without cluttering the console. - This change is aimed at improving the usability of the component during development while maintaining adherence to TypeScript standards.
commit: |
- Updated the @Tresjs/core dependency from version be3280b to 0731c19 in package.json and playground/vue/package.json for improved functionality. - Adjusted pnpm-lock.yaml to reflect the updated version of @Tresjs/core across all relevant sections.
- Replaced the use of destructured state from `useTexture` with direct texture loading using `TextureLoader` in the `Ocean.vue` component for improved clarity and performance. - Updated the `watchEffect` in `Precipitation.vue` to use a more descriptive variable name for the texture state, enhancing code readability. - Ensured that texture loading logic is consistent across components, aligning with best practices for resource management.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.