fix(dts-generator): support rest parameters in functions in nested types #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.) When no param and no return type is given, generate "Function" instead of "()=>void" to allow passing parameters, just like it happens in simple function types. 2.) When api.json contains: Object<string,function(...any)>|function Then the d.ts file will contain: Record<string, (...p1: any) => void> | Function; Before this fix, the function had no parameter.
487c2c2 to
b39de70
Compare
codeworrior
requested changes
Jun 23, 2025
| | TypeReference | ||
| | TypeLiteral | ||
| | UnionType | ||
| | IntersectionType | ||
| | ArrayType | ||
| | FunctionType | ||
| | LiteralType | ||
| | NativeTSTypeExpression; | ||
| | NativeTSTypeExpression | ||
| ) & { repeatable?: boolean }; |
There was a problem hiding this comment.
It is an anachronism in JSDoc that the "repeatable" information is attached to the type (because JSDoc has no parameter names in function signatures, only types) and our api.json inherited this from JSDoc.
I would rather convert this in the ts-ast-type-builder as we do already for the optional flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When api.json contains:
Object<string,function(...any)>|function
Then the d.ts file will contain:
Record<string, (...p1: any) => void> | Function;
Before this fix, the function had no parameter.