chore: update dependencies #510
Conversation
| @@ -255,10 +255,10 @@ function genModule(ast: Module) { | |||
| text += `declare module "${ast.name}" {` + NL; | |||
| text += APPEND_ITEMS(ast.imports, genImport); | |||
| text += APPEND_ITEMS(ast.exports, genExport); | |||
| (text += APPEND_ITEMS(ast.namespaces, (namespace: Namespace) => | |||
| ((text += APPEND_ITEMS(ast.namespaces, (namespace: Namespace) => | |||
| genNamespace(namespace, { export: namespace.export }), | |||
| )), | |||
There was a problem hiding this comment.
This looks strange. Shouldn't the comma at the end of line 260 rather be a semicolon? I see no reason why this should be a sequence...
There was a problem hiding this comment.
doesn't change the behavior and was like this before, but you are right. I'll fix it to make the code more readable.
| @@ -46,13 +46,13 @@ export function createJSDocCenterPart(info: APIMember, lines: string[] = []) { | |||
| lines.push(""); | |||
| } | |||
|
|
|||
| info.since ? lines.push("@since " + info.since) : "", | |||
| (info.since ? lines.push("@since " + info.since) : "", | |||
There was a problem hiding this comment.
same, also looks strange. Semicolon?
There was a problem hiding this comment.
same. The third part of the ternary statements (empty string) also makes no sense
| @@ -202,8 +202,8 @@ function generateSettingsInterface( | |||
| propertySignature, | |||
| buildJSDocStringFromLines(createJSDocCenterPart(association)), | |||
| ); | |||
| factory.createKeywordTypeNode(ts.SyntaxKind.StringKeyword), | |||
| interfaceProperties.push(propertySignature); | |||
| (factory.createKeywordTypeNode(ts.SyntaxKind.StringKeyword), | |||
There was a problem hiding this comment.
my biggest doubts are about this one. The others work as intended despite the comma, but here line 205 does create a node which is never used
|
Seems like prettier uncovered some syntactic Murks. See #511 |
No description provided.