Fix illegal calls to IAND in imnidh.f #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes Unidata#43 by making all arguments to IAND() INTEGER*2. I have not tested this fix with real radar data, but I have tried calling the function with a variety of integers, and the return values do agree with what the previous version returned when compiled with gfortran 8.3.
eb78577 to
8339694
Compare
|
@sgdecker I have rebased this one as well, are you still happy with the change? |
|
Yes, I think this one is fine as well. |
akrherz
approved these changes
Feb 28, 2022
Closed
|
Confirmed this fix works on Ubuntu 20.04, I didn't seem to have any problems installing with gfortran version 9.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #43 by making all arguments to IAND() INTEGER*2. I have
not tested this fix with real radar data, but I have tried calling the
function with a variety of integers, and the return values do agree
with what the previous version returned when compiled with gfortran 8.3.