Skip to content

fix: source_map_support: false disables source maps #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jadenbertino
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

Hey @Unitech

  • In the ecosystem (JSON) file
    • if you set disable_source_map_support: true, this will correctly disable source maps
    • but if you set source_map_support: false, this has no effect - source maps will still be detected.
  • This PR ensures that setting source_map_support: false correctly disables source maps, so that it has the same behavior as setting disable_source_map_support: true
  • This is related to (but does not fix) Add support for source map flags to pm2-runtime #5003. I had similar issues getting Sentry to work correctly because pm2 was detecting source map files even though I had already set source_map_support: false. This fix prevents that issue from happening again with other people using pm2 with ecosystem files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy