add docker compose #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Docker Compose configuration updates to support new environment variables and consolidates volume mounting configuration for the ActiveLoop NeoHorizon application. The main purpose is to introduce new inference retriever URL configurations and streamline the Docker Compose setup.
- Adds two new environment variables for inference retriever v1 deployment URLs (ingestion and query)
- Consolidates deeplake volume mounting from individual services to shared configuration
- Reorganizes restart policy placement for consistency across compose files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose.yaml | Adds new environment variables, consolidates volume mounting to shared config, and removes duplicate volume declarations from individual services |
| docker-compose.nomodel.yaml | Same environment variable and volume mounting changes as main compose file for no-model deployment variant |
| docker-compose.apps.yaml | Adds new environment variables and reorganizes restart policy placement for apps-only deployment variant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.