Description
This image file:
results in this exception being raised:
Traceback (most recent call last):
File "code.py", line 34, in <module>
File "/lib/adafruit_imageload/__init__.py", line 92, in load
File "/lib/adafruit_imageload/png.py", line 116, in load
IndexError: x must be 0-8
It traces to this line: https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad/blob/main/adafruit_imageload/png.py#L116
bmp[x + pixel, y] = (byte >> ((pixels_per_byte - pixel - 1) * depth)) & pixmask
I think the root cause for this might be related to something mentioned here in section 2.3: https://www.w3.org/TR/PNG-DataRep.html
Scanlines always begin on byte boundaries. When pixels have fewer than 8 bits and the scanline width is not evenly divisible by the number of pixels per byte, the low-order bits in the last byte of each scanline are wasted. The contents of these wasted bits are unspecified.
It seems to me our implementation doesn't account for this because we always try to access the pixel at x index x + pixel
without regard for the width. This image has width 9
, and the pixels per byte is 4
, so the last byte of the scanline will contain 3 "extra" pixels worth of data that should be ignored.
modifying png load like this allows it to load and render correctly:
if x + pixel < width:
bmp[x + pixel, y] = (byte >> ((pixels_per_byte - pixel - 1) * depth)) & pixmask
However I haven't done much testing with other images to ensure it doesn't introduce other problems.