Skip to content

fix(compiler-cli): enhance signal checks to handle negat… #59970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): enhance signal checks to handle negat… #59970

wants to merge 1 commit into from
+30 −8

Conversation

aldillek
Copy link
Contributor

…ed signals

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

@Component({
  selector: 'app-root',
  template: ` {{ test }} {{ !test }} `,
  styles: '',
})
export class AppComponent{
  readonly test = signal(false)
}

For this code only first interpolation is marked as not invoked.

What is the new behavior?

Now not invoked negated signals are marked.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Feb 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 16, 2025
@pullapprove pullapprove bot requested a review from JoostK February 16, 2025 11:58
@aldillek aldillek force-pushed the fix-check-not-invoked-signal branch 3 times, most recently from c2b410c to 63ec4bb Compare February 16, 2025 16:34
@aldillek aldillek changed the title fix(compiler-cli): enhance interpolated signal checks to handle negat… fix(compiler-cli): enhance signal checks to handle negat… Feb 16, 2025
@JeanMeche JeanMeche requested a review from crisbeto May 21, 2025 15:28
@JeanMeche JeanMeche force-pushed the fix-check-not-invoked-signal branch from 63ec4bb to e7c2e29 Compare May 21, 2025 16:07
@aldillek @JeanMeche
fix(compiler-cli): add signal checks to handle negated calls
40fc150 
By adding these checks, we can find scenarios where a signal was expected to be called but wasn't.
@JeanMeche JeanMeche force-pushed the fix-check-not-invoked-signal branch from e7c2e29 to 40fc150 Compare May 21, 2025 16:16
@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label May 23, 2025
@JeanMeche
Copy link
Member

JeanMeche commented May 23, 2025 •
edited
Loading

A TGP surfaced a handful of legitimate breakages, this will require a cleanup in G3 (Google's monorepo) to land

@aldillek
Copy link
Contributor Author

@JeanMeche Thanks for feedback. Could you please share more info about what's breaking? It would help me update PR.

@JeanMeche
Copy link
Member

The improvement looks fine, it actually detected negated signals that we need to fix !

@thePunderWoman thePunderWoman removed the request for review from JoostK June 5, 2025 12:36
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jun 5, 2025
@JeanMeche
Copy link
Member

TGP is "Green"

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 6, 2025
@AndrewKushnir AndrewKushnir removed the action: global presubmit The PR is in need of a google3 global presubmit label Jun 9, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit b7ab5fa.

The changes were merged into the following branches: main

@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Jun 11, 2025
@JeanMeche JeanMeche mentioned this pull request Jun 25, 2025
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: global presubmit The PR is in need of a google3 global presubmit action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@aldillek @JeanMeche @AndrewKushnir @crisbeto @thePunderWoman
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy