Skip to content

fix(docs-infra): update docs-alert and tests #60829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

Patch version of #60827

Before this commit, the docs-alert tests were failing. This also ensures that `NOTE:`, `TIP:` and others are always capitalized.

(cherry picked from commit ab5986dd5685d36e209972916cddb9dca8e0a557)
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 10, 2025
@alan-agius4 alan-agius4 requested review from JeanMeche and removed request for jelbourn, pkozlowski-opensource, alxhub and josephperrott April 10, 2025 12:57
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Apr 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 10, 2025
@alan-agius4 alan-agius4 added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable labels Apr 10, 2025
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Apr 10, 2025

Caretaker note: disabling pull approve is this is just a doc change that was already done on main and is just a cherry-pick

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 10, 2025
@kirjs
Copy link
Contributor

kirjs commented Apr 10, 2025

This PR was merged into the repository by commit 77c6041.

The changes were merged into the following branches: 19.2.x

kirjs pushed a commit that referenced this pull request Apr 10, 2025
Before this commit, the docs-alert tests were failing. This also ensures that `NOTE:`, `TIP:` and others are always capitalized.

(cherry picked from commit ab5986dd5685d36e209972916cddb9dca8e0a557)

PR Close #60829
@kirjs kirjs closed this Apr 10, 2025
@alan-agius4 alan-agius4 deleted the docs-alert-patch branch April 10, 2025 15:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs-infra Angular.dev application and infrastructure merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy