Skip to content

refactor(devtools): main nav #62242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

hawkgs
Copy link
Member

@hawkgs hawkgs commented Jun 24, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the new behavior?

Keep only the navigation elements within the nav rather than all toolbar elements. This is purely a semantical change that also eliminates the need for the .nav-wrapper.

Does this PR introduce a breaking change?

  • Yes
  • No

@hawkgs hawkgs requested a review from JeanMeche June 24, 2025 14:29
@ngbot ngbot bot added this to the Backlog milestone Jun 24, 2025
@hawkgs hawkgs force-pushed the devtools/refactor-nav branch 2 times, most recently from c6e4047 to 75e8772 Compare June 24, 2025 15:09
@hawkgs hawkgs added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 24, 2025
Keep only the navigation elements within the `nav` rather than all toolbar elements.
@hawkgs hawkgs force-pushed the devtools/refactor-nav branch from 75e8772 to 7a0deb1 Compare June 24, 2025 15:12
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 27, 2025
@thePunderWoman thePunderWoman added target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Jun 27, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit f943505.

The changes were merged into the following branches: main

@hawkgs hawkgs deleted the devtools/refactor-nav branch June 27, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: devtools target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy