Skip to content

fix(core): avoid injecting internal error handler from a destroyed injector #62275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(core): avoid injecting internal error handler from a destroyed injector #62275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/core/src/render3/instructions/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,17 @@ export function handleUncaughtError(lView: LView, error: any): void {
if (!injector) {
return;
}
const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);
errorHandler?.(error);
// Question (atscott): there's no `destroyed` property on that injector...
// Should we wrap it in a try-catch and re-throw in a timer?
// Or there's any other precise solution?
try {
const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);
errorHandler?.(error);
} catch {
setTimeout(() => {
throw error;
});
}
}

/**
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy