Skip to content

fix(core): checks if body exists before continuing #62768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thePunderWoman
Copy link
Contributor

This fixes a case in which the document exists, but the body does not.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 23, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 23, 2025
This fixes a case in which the document exists, but the body does not.
@thePunderWoman thePunderWoman force-pushed the animate-instructions-fix branch from 3baa40d to aec0b6b Compare July 23, 2025 16:24
@@ -32,6 +32,8 @@ const areAnimationSupported =
(typeof ngServerMode === 'undefined' || !ngServerMode) &&
typeof document !== 'undefined' &&
// tslint:disable-next-line:no-toplevel-property-access
typeof document.body !== 'undefined' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up: we should be able to check document.documentElement instead.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jul 23, 2025
@kirjs
Copy link
Contributor

kirjs commented Jul 23, 2025

This PR was merged into the repository by commit 593cc8a.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 593cc8a Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy