GH-46375: [C++] Add adapters/orc to Meson configuration #46409
Conversation
|
|
| [wrap-file] | ||
| source_url = https://www.apache.org/dyn/closer.lua/orc/orc-1.9.6/orc-1.9.6.tar.gz?action=download | ||
| source_fallback_url = https://dlcdn.apache.org/orc/orc-1.9.6/orc-1.9.6.tar.gz | ||
| source_filename = orc-1.9.6.tar.gz |
There was a problem hiding this comment.
I had to intentionally limit the version of orc < 2, as in 2.0 they introduced a new externalproject called orc-format that contains just the proto files for orc. Meson wrapping a CMake configuration to call an ExternalProject that itself is not a CMake project seemed pretty fragile...
|
@github-actions crossbow submit *meson |
|
Revision: 89b9a3f Submitted crossbow builds: ursacomputing/crossbow @ actions-eb6663e1e5
|
|
This one might be challenging to get right with Apache ORC's CMake configuration; I'm going to spend some time to see if we can upstream ORC to the Meson wrapdb first |
|
I'm not familiar with Meson. But let me know if you need any help from Apache ORC. |
Rationale for this change
This continues building out the functionality of the Meson integration
What changes are included in this PR?
This adds the adapters/orc directory to Meson
Are these changes tested?
Yes
Are there any user-facing changes?
No