-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Resource Limits to Backups and Object Storage #10017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
…ected size should be the total volume size.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10017 +/- ##
============================================
+ Coverage 16.02% 16.08% +0.06%
- Complexity 13146 13177 +31
============================================
Files 5658 5659 +1
Lines 496312 496856 +544
Branches 60109 60168 +59
============================================
+ Hits 79537 79938 +401
- Misses 407926 407973 +47
- Partials 8849 8945 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12288 |
@blueorangutan package |
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12341 |
@blueorangutan test |
@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-12328)
|
Doc PR : apache/cloudstack-documentation#461 This PR fixes apache#8638 == Description Four new Resource Types have been added. Admin can configure corresponding resource limits for the tenants at different levels (domain, account, project) User dashboard's Storage section will show the new resources, their limits and current usage. 1. backup - No. of backups used by the account 2. backup_storage - Backup storage allocated for the account 3. bucket - No. of buckets used by the accounts 4. object_storage - Object storage allocated for the account. Some other related changes done to BnR framework: 1. Maximum number of Backups to retain can be specified while creating Backup schedules, similar to Scheduled snapshots. 2. Oldest Scheduled backup of the same interval type will be deleted once the number reaches the configured max Backups value. 3. Code refactor: Moved syncBackups method from BackupProvider to the framework BackupManagerImpl, as it is a common functionality and all providers were using duplicated code. Changes done to the Object Storage Framework 1. Quota parameter is made mandatory while creating a bucket. Bucket quota is considered to be the allocated space and will be used to enforce Resource limits. == Schema Changes: 1. New Column `max_backups` added to `backup_schedule` table 4. New Column `backup_interval_type` added to `backups` table == Api Changes: 1. createBackup: new Parameter `scheduleid`. It should be specified whenever a scheduled backup is created. This will translate to the `backup_interval_type` in the `backups` table. 3. createBackupScheduke: new Parameter `max_backups`. To specify maximum number of backups to retain for the given schedule. == Configurations: |Setting |Scope |Default Value |Description| |-------|--------|--------------|-----------| |backup.max.hourly |Global |8 |Maximum recurring hourly backups to be retained for an instance| |backup.max.daily |Global |8 |Maximum recurring daily backups to be retained for an instance| |backup.max.weekly |Global |8 |Maximum recurring weekly backups to be retained for an instance| |backup.max.monthly |Global |8 |Maximum recurring monthly backups to be retained for an instance| |max.account.backups| Global| 20 | The default maximum number of backups that can be created for an account| |max.account.backup.storage| Global| 400 | The default maximum backup storage space (in GiB) that can be used for an account| |max.domain.backups| Global| 40 | The default maximum number of backups that can be created for an domain| |max.domain.backup.storage| Global| 800 | The default maximum backup storage space (in GiB) that can be used for an domain| |max.project.backups| Global| 20 | The default maximum number of backups that can be created for an project| |max.project.backup.storage| Global| 400 | The default maximum backup storage space (in GiB) that can be used for an project| |Setting |Scope |Default Value |Description| |-------|--------|--------------|-----------| |max.account.buckets| Global| 20 | The default maximum number of buckets that can be created for an account| |max.account.object.storage| Global| 400 | The default maximum object storage space (in GiB) that can be used for an account| |max.domain.buckets| Global| 40 | The default maximum number of buckets that can be created for an domain| |max.domain.object.storage| Global| 800 | The default maximum object storage space (in GiB) that can be used for an domain| |max.project.buckets| Global| 20 | The default maximum number of buckets that can be created for an project| |max.project.object.storage| Global| 400 | The default maximum object storage space (in GiB) that can be used for an project| Co-authored-by: Daan Hoogland <daan@onecht.net> Co-authored-by: Lucas Martins <56271185+lucas-a-martins@users.noreply.github.com> Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br> Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Doc PR : apache/cloudstack-documentation#461
This PR fixes #8638
Description
Four new Resource Types have been added. Admin can configure corresponding resource limits for the tenants at different levels (domain, account, project)
User dashboard's Storage section will show the new resources, their limits and current usage.
Some other related changes done to BnR framework:
Changes done to the Object Storage Framework
Schema Changes:
max_backups
added tobackup_schedule
tablebackup_interval_type
added tobackups
tableApi Changes:
scheduleid
. It should be specified whenever a scheduled backup is created. This will translate to thebackup_interval_type
in thebackups
table.max_backups
. To specify maximum number of backups to retain for the given schedule.Configurations:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?