[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated #10975

nvazquez · 2025-06-06T01:03:04Z

Description

This PR ensures the converted/imported instances preserve the source VM boot mode and boot type.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Verify the source VM boot type and boot mode before importing:
Import Vmware VM using KVM host for conversion having virt-v2v and ovftool installed
Verify the imported VM contains the expected boot mode and boot type:

How did you try to break this feature and the system with this change?

…es to be migrated

nvazquez · 2025-06-06T01:06:52Z

@blueorangutan package

blueorangutan · 2025-06-06T01:08:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-06-06T01:10:44Z

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (8f2735a) to head (ce013d5).
Report is 34 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.20   #10975    +/-   ##
==========================================
  Coverage     16.15%   16.15%            
- Complexity    13273    13275     +2     
==========================================
  Files          5657     5656     -1     
  Lines        497898   497792   -106     
  Branches      60374    60370     -4     
==========================================
+ Hits          80435    80440     +5     
+ Misses       408505   408399   -106     
+ Partials       8958     8953     -5

Flag	Coverage Δ
uitests	`4.00% <ø> (+<0.01%)`	⬆️
unittests	`17.01% <60.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-06-06T02:15:18Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13641

nvazquez · 2025-06-06T03:40:57Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2025-06-06T03:42:04Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2025-06-06T22:02:49Z

[SF] Trillian test result (tid-13475)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63409 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13475-vmware-70u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	`Error`	150.11	test_deploy_vms_in_parallel.py
test_01_scale_vm	`Error`	1.52	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	1.40	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	1.39	test_scale_vm.py

nvazquez · 2025-06-09T16:47:43Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2025-06-09T16:50:05Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2025-06-09T16:59:01Z

[SF] Trillian Build Failed (tid-13485)

github-actions · 2025-06-10T11:05:53Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland

logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.

nvazquez · 2025-06-16T12:44:10Z

@blueorangutan package

blueorangutan · 2025-06-16T12:46:06Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti

clgtm

blueorangutan · 2025-06-16T14:16:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13792

nvazquez · 2025-07-08T12:32:02Z

@blueorangutan package

blueorangutan · 2025-07-08T12:34:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-08T14:54:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14100

nvazquez · 2025-07-08T15:11:04Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2025-07-08T15:12:05Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

sureshanaparti · 2025-07-21T06:42:54Z

@blueorangutan package

blueorangutan · 2025-07-21T06:44:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-21T07:55:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14275

sureshanaparti · 2025-07-21T10:41:51Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2025-07-21T10:44:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

shwstppr

Added some comments

shwstppr · 2025-07-21T12:34:17Z

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

@@ -1564,7 +1573,8 @@ private UserVm importUnmanagedInstanceFromHypervisor(DataCenter zone, Cluster cl
                        template, displayName, hostName, CallContext.current().getCallingAccount(), owner, userId,
                        serviceOffering, dataDiskOfferingMap,
                        nicNetworkMap, nicIpAddressMap,
-                        details, migrateAllowed, forced, true);
+                        details, migrateAllowed, forced, true,
+                        unmanagedInstance.getBootType(), unmanagedInstance.getBootMode());


@nvazquez do we need to pass them here as they are already returned by unmanagedInstance and it is already passed?

Good catch, thanks - fixed

shwstppr · 2025-07-21T12:43:03Z

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

@@ -1259,6 +1262,12 @@ private UserVm importVirtualMachineInternal(final UnmanagedInstanceTO unmanagedI
        return userVm;
    }

+    private void addImportingVMBootTypeAndModeDetails(String bootType, String bootMode, Map<String, String> allDetails) {
+        if (StringUtils.isNotBlank(bootType) && bootType.equalsIgnoreCase("uefi") && StringUtils.isNotBlank(bootMode)) {


Do we need to check if bootMode is blank or not?
In a similar code block in #11218, I added a deployasis check as I saw it in UserVmManagerImpl.commitUserVm, not sure if it is worth adding?

I think the deployasis check doesn't apply here, since Vmware to KVM migrations won't have that boolean enabled then converted VMs will never retain the boot mode and type. In case the VM is deploy as is then the boot mode and type will be preserved.
For the bootMode I think we do need to check if its not blank as that is the value we are adding as detail for the converted VM.

blueorangutan · 2025-07-22T05:05:21Z

[SF] Trillian test result (tid-13833)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13833-vmware-70u3.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2025-07-23T17:41:12Z

@nvazquez can you check the outstanding comments.

nvazquez · 2025-07-24T10:49:55Z

Thanks @shwstppr for the review, comments addressed

@blueorangutan package

blueorangutan · 2025-07-24T10:52:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-24T12:14:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14346

borisstoyanov

LGTM, manually checked the attributes are passed to imported instances

[Vmware to KVM Migration] Preserve boot type and boot mode of instanc…

c2b4dc2

…es to be migrated

nvazquez requested review from shwstppr, NuxRo, DaanHoogland and sureshanaparti June 6, 2025 01:03

nvazquez added component:kvm component:vmware component:migration labels Jun 6, 2025

boring-cyborg bot added the component:UI label Jun 6, 2025

github-actions bot added the status:has-conflicts label Jun 10, 2025

Merge branch '4.20' into 420-vmware2kvm-preserve-boot

2168835

github-actions bot removed the status:has-conflicts label Jun 13, 2025

Restore end of line

bce6578

DaanHoogland approved these changes Jun 16, 2025

View reviewed changes

DaanHoogland mentioned this pull request Jun 16, 2025

the method importVirtualMachineInternal(..) now is 153 lines and takes 21 parameters. #11033

Open

Extract lines to new method

6f68eca

sureshanaparti approved these changes Jun 16, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Jul 9, 2025

nvazquez added this to the 4.20.2 milestone Jul 9, 2025

shwstppr reviewed Jul 21, 2025

View reviewed changes

sureshanaparti assigned NuxRo Jul 23, 2025

Address review comments

ce013d5

borisstoyanov approved these changes Jul 25, 2025

View reviewed changes

sureshanaparti removed the status:needs-testing label Jul 25, 2025

sureshanaparti merged commit a51a04e into apache:4.20 Jul 25, 2025
24 of 26 checks passed

DaanHoogland deleted the 420-vmware2kvm-preserve-boot branch July 25, 2025 07:01

[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated #10975

[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated #10975

Uh oh!

Conversation

nvazquez commented Jun 6, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Jun 6, 2025

Uh oh!

blueorangutan commented Jun 6, 2025

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jun 6, 2025

Uh oh!

nvazquez commented Jun 6, 2025

Uh oh!

blueorangutan commented Jun 6, 2025

Uh oh!

blueorangutan commented Jun 6, 2025

Uh oh!

nvazquez commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jun 16, 2025

Uh oh!

blueorangutan commented Jun 16, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 16, 2025

Uh oh!

nvazquez commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

nvazquez commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

sureshanaparti commented Jul 21, 2025

Uh oh!

blueorangutan commented Jul 21, 2025

Uh oh!

blueorangutan commented Jul 21, 2025

Uh oh!

sureshanaparti commented Jul 21, 2025

Uh oh!

blueorangutan commented Jul 21, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Jul 21, 2025

codecov bot commented Jun 6, 2025 •

edited

Loading