Skip to content

pre-commit: upgrade markdownlint to the latest version #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025

Conversation

jbampton
Copy link
Member

Description

This PR moves markdownlint to the latest version.

https://github.com/igorshubovych/markdownlint-cli/releases

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally pre-commit run --all-files

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.89%. Comparing base (6d5cefd) to head (a000824).

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #11066   +/-   ##
======================================
  Coverage   3.89%    3.89%           
======================================
  Files        417      417           
  Lines      33973    33973           
  Branches    6096     6096           
======================================
  Hits        1324     1324           
  Misses     32491    32491           
  Partials     158      158           
Flag Coverage Δ
uitests 3.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 requested a review from Copilot July 23, 2025 11:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the markdownlint tool version from v0.43.0 to v0.45.0 in the pre-commit configuration and disables a new linting rule (MD059) that was introduced in the updated version.

  • Updates markdownlint-cli from v0.43.0 to v0.45.0 in pre-commit configuration
  • Disables the new MD059 rule for descriptive link text to maintain backward compatibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.pre-commit-config.yaml Updates markdownlint version from v0.43.0 to v0.45.0
.github/linters/.markdown-lint.yml Disables the new MD059 rule for descriptive link text

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Jul 23, 2025
@DaanHoogland DaanHoogland merged commit fb3bb3f into apache:main Jul 23, 2025
25 of 26 checks passed
@jbampton jbampton deleted the upgrade-markdownlint branch July 23, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy