Skip to content

UI: Fix OS Type displayed for a VM #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

UI: Fix OS Type displayed for a VM #11075

merged 3 commits into from
Jul 24, 2025

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes the OS type displayed for a VM

Before fix:
image

After fix:
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.74%. Comparing base (1fbe1d7) to head (dcbc9d3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11075   +/-   ##
=========================================
  Coverage     16.74%   16.74%           
- Complexity    14061    14063    +2     
=========================================
  Files          5724     5724           
  Lines        507787   507785    -2     
  Branches      61733    61733           
=========================================
+ Hits          85038    85039    +1     
+ Misses       413266   413263    -3     
  Partials       9483     9483
Flag Coverage Δ
uitests 3.89% <ø> (+<0.01%) ⬆️
unittests 17.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11075 (QA-JID-651)

@shwstppr
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11075 (QA-JID-652)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

shwstppr
shwstppr approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on QA server

image

image

fmaximus
fmaximus requested changes Jul 1, 2025
View reviewed changes
fmaximus
fmaximus approved these changes Jul 2, 2025
View reviewed changes
@shwstppr
Copy link
Contributor

shwstppr commented Jul 4, 2025 •
edited
Loading

@Pearl1594 can this be marked ready for review/merge?

DaanHoogland
DaanHoogland approved these changes Jul 5, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594 Pearl1594 marked this pull request as ready for review July 8, 2025 12:48
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11075 (QA-JID-684)

@shwstppr shwstppr closed this Jul 24, 2025
@shwstppr shwstppr reopened this Jul 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sureshanaparti
Copy link
Contributor

Verified with QA simulator env.

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jul 24, 2025
@sureshanaparti sureshanaparti merged commit 071e612 into main Jul 24, 2025
54 of 73 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 24, 2025
@sureshanaparti sureshanaparti deleted the fix-os-type branch July 24, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@fmaximus fmaximus fmaximus approved these changes

Assignees
No one assigned
Labels
component:UI
Projects
Apache CloudStack 4.21.0
Status: Done
Milestone
4.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Pearl1594 @blueorangutan @shwstppr @sureshanaparti @DaanHoogland @fmaximus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy