UI support for deploy a VM from volume/snapshot #11164
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11164 +/- ##
============================================
+ Coverage 17.17% 17.34% +0.17%
- Complexity 14993 15186 +193
============================================
Files 5869 5883 +14
Lines 521728 524501 +2773
Branches 63506 64003 +497
============================================
+ Hits 89604 90999 +1395
- Misses 422053 423219 +1166
- Partials 10071 10283 +212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14162 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds UI functionality to deploy virtual machines from existing volumes and disk snapshots, expanding beyond the existing template and ISO options.
Key changes:
- Added volume and snapshot radio button options in the image selection UI
- Implemented volume and snapshot fetching logic with filtering for unattached volumes and root snapshots
- Added form handling and validation for volume and snapshot deployment parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/views/compute/wizard/OsBasedImageSelection.vue | Added radio buttons for volume and snapshot selection options |
| ui/src/views/compute/DeployVM.vue | Core implementation including form fields, data fetching, validation, and deployment logic for volumes and snapshots |
| ui/public/locales/en.json | Added localization strings for volume and snapshot descriptions |
|
@slavkap can you check the Copilot comments, are they relevant? |
|
UI build: ✔️ |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14389 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14396 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14416 |
07c5d50 to
693539d
Compare
|
@blueorangutan package |
|
@slavkap a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14421 |
|
@slavkap The volume & snapshots shown in deployment form are not relevant to the category. Volumes are not listed, checked in env with some ROOT & DATA volumes, also uploaded volumes. Can you please check.
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@slavkap can you check the conflicts |
ui support to deploy a virtual machine with existing volume or a disk snapshot
Removed OS/User options when using volume/snapshot refactoring
693539d to
ca09591
Compare
@sureshanaparti, I have removed the option to choose OS/user because those aren't used with the snapshot/volume option |
|
@blueorangutan package |
|
@slavkap a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14473 |
|
LGTM, able to create instance
UI listed only detached volumes in Ready state, and snapshots of ROOT volumes. Volumes in Zone-wide pools are only supported for instance creation. Otherwise, it fails with "Deployment of virtual machine is supported only for Zone-wide storage pools". @slavkap The parameters - oscategoryid, volumefilter, details, isvnf, showicon are not applicable while listing volumes, and oscategoryid, snapshotfilter, details, isvnf, showicon are not applicable while listing snapshots. Also, listOsCategories is called before listVolumes and listSnapshots, which is not required. Can you check this. |
removed unnecessary API params
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
removed invoking of listOsCategories when listing volumes or snapshots
|
Verified the list volumes and snapshots calls locally, these parameters are removed. Also, listOsCategories is not called. Thanks @slavkap |
Description
This PR adds a UI option to deploy a virtual machine with an existing volume or a disk snapshot
These changes depend on #10503
Types of changes
Feature/Enhancement Scale
Screenshots (if appropriate):
The users will have the option to choose how to deploy a new virtual machine - Template/ISO/Volume/Snapshot
How Has This Been Tested?
manual tests