Skip to content

Fix local storage pool disconnect issue #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix local storage pool disconnect issue #11200

wants to merge 1 commit into from

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Jul 15, 2025 •
edited
Loading

Description

This PR fixes the issue #11104 which is a regression from #10381. Prior to the PR #10381 local storage connection management is skipped in StoragePoolMonitor. Here in this PR, added the same workflow.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  1. Had an environment with a KVM host and local storage
  2. Tried restarting the KVM agent
  3. Before this fix, local storage is disconnected on host, so was unable to use the local storage even though it shows in UI. Now with the fix, storage connection remains the same and I'm able to use the storage for volume provisioning.

How did you try to break this feature and the system with this change?

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@harikrishna-patnala harikrishna-patnala linked an issue Jul 15, 2025 that may be closed by this pull request
KVM local storage pool gets removed from hosts #11104
Open
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (6059724) to head (26dcad9).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...com/cloud/storage/listener/StoragePoolMonitor.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11200      +/-   ##
============================================
- Coverage     16.58%   16.56%   -0.02%     
- Complexity    13991    14009      +18     
============================================
  Files          5745     5758      +13     
  Lines        510757   511579     +822     
  Branches      62144    62193      +49     
============================================
+ Hits          84690    84743      +53     
- Misses       416598   417369     +771     
+ Partials       9469     9467       -2
Flag Coverage Δ
uitests 3.91% <ø> (-0.01%) ⬇️
unittests 17.46% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14191

@harikrishna-patnala harikrishna-patnala added this to the 4.21.0 milestone Jul 15, 2025
sureshanaparti
sureshanaparti approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland
DaanHoogland approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, clgtm.

@blueorangutan
Copy link

[SF] Trillian test result (tid-13863)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55974 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11200-t13863-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland mentioned this pull request Jul 24, 2025
Open
@sureshanaparti sureshanaparti requested a review from Pearl1594 July 25, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

@kiranchavala kiranchavala

Labels
component:storage status:needs-testing
Projects
Apache CloudStack 4.21.0
Status: In Progress
Milestone
4.21.0
Development

Successfully merging this pull request may close these issues.

KVM local storage pool gets removed from hosts
5 participants
@harikrishna-patnala @blueorangutan @sureshanaparti @DaanHoogland @kiranchavala
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy