Added events for snapshots, vmsnapshots, internalLB operations #11230

harikrishna-patnala · 2025-07-17T07:39:42Z

Description

This PR adds few fixes/improvements for events for few operations on snapshots, vmsnapshots, internalLB.

This addresses few items in the issue #8771

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-07-17T07:47:37Z

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (06c80cd) to head (230fd25).
Report is 5 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...user/snapshot/CreateSnapshotFromVMSnapshotCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #11230      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
+ Complexity    11364    11359       -5     
============================================
  Files          5415     5415              
  Lines        475888   475909      +21     
  Branches      58094    58096       +2     
============================================
- Hits          72256    72226      -30     
- Misses       395546   395602      +56     
+ Partials       8086     8081       -5

Flag	Coverage Δ
uitests	`4.28% <ø> (+<0.01%)`	⬆️
unittests	`15.90% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti

clgtm

Copilot

Pull Request Overview

This PR adds event logging and annotations for snapshot, VM snapshot, and internal load balancer operations to improve system auditing and monitoring. The changes focus on adding ActionEvent annotations to existing methods and updating event handling.

Adds ActionEvent annotations to snapshot creation, host maintenance, and internal LB operations
Removes manual event logging in favor of annotation-based approach for host maintenance
Updates test infrastructure to mock ActionEventUtils for internal LB tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
SnapshotManagerImpl.java	Adds event annotation for snapshot creation from VM snapshot
ResourceManagerImpl.java	Adds event annotations for host maintenance and reconnect operations, removes manual event call
InternalLoadBalancerVMManagerImpl.java	Adds event annotations for internal LB VM start and stop operations
InternalLBVMServiceTest.java	Updates test to mock ActionEventUtils static calls
CreateSnapshotFromVMSnapshotCmd.java	Adds getApiResourceId method for proper resource identification

Copilot · 2025-07-22T06:45:41Z

...oadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java

 import org.apache.cloudstack.context.CallContext;
 import org.apache.cloudstack.network.lb.InternalLoadBalancerVMService;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.mockito.BDDMockito;
 import org.mockito.Matchers;


The import 'org.mockito.Matchers' is deprecated. Use 'org.mockito.ArgumentMatchers' instead, which is already imported.

Suggested change

import org.mockito.Matchers;

@harikrishna-patnala , does this make sense?
it requires line 116 to have a simple adjustment as well.

Done @DaanHoogland

sureshanaparti · 2025-07-22T06:45:50Z

@blueorangutan package

blueorangutan · 2025-07-22T06:48:07Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-22T07:51:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14291

harikrishna-patnala · 2025-07-24T08:13:03Z

@blueorangutan package

blueorangutan · 2025-07-24T08:14:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

anyLong() is already statically imported, so no need for importing ArgumentMatchers.

...oadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java

blueorangutan · 2025-07-24T10:05:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14343

Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland

clgtm

DaanHoogland · 2025-07-25T08:11:27Z

@blueorangutan package

blueorangutan · 2025-07-25T08:12:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-25T10:33:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14364

Added events for snapshots, vmsnapshots, internalLB operations

2b578ae

boring-cyborg bot added component:api component:networking component:storage labels Jul 17, 2025

harikrishna-patnala linked an issue Jul 17, 2025 that may be closed by this pull request

Events not generating for BaseCmd classes #8771

Open

harikrishna-patnala requested a review from kiranchavala July 17, 2025 08:07

harikrishna-patnala added 2 commits July 18, 2025 08:32

Fix tests

33db636

Fix import

876fba4

harikrishna-patnala closed this Jul 22, 2025

harikrishna-patnala reopened this Jul 22, 2025

sureshanaparti reviewed Jul 22, 2025

View reviewed changes

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated Show resolved Hide resolved

Update server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

a16790d

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti requested a review from Copilot July 22, 2025 06:45

sureshanaparti approved these changes Jul 22, 2025

View reviewed changes

Copilot AI reviewed Jul 22, 2025

View reviewed changes

boring-cyborg bot added component:management-server component:secondary-storage component:ssvm component:UI component:vmware labels Jul 24, 2025

small fix

c620018

harikrishna-patnala force-pushed the AddedFewEventsImprovements branch from 3fbb7f7 to c620018 Compare July 24, 2025 08:12

DaanHoogland reviewed Jul 24, 2025

View reviewed changes

...oadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java Outdated Show resolved Hide resolved

...oadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java Outdated Show resolved Hide resolved

harikrishna-patnala and others added 2 commits July 25, 2025 12:17

Unit test - ArgumentMatchers change

134f7e7

Co-authored-by: dahn <daan.hoogland@gmail.com>

Unit test - ArgumentMatchers change

230fd25

Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland approved these changes Jul 25, 2025

View reviewed changes

DaanHoogland added this to the 4.19.4 milestone Jul 25, 2025

Added events for snapshots, vmsnapshots, internalLB operations #11230

Are you sure you want to change the base?

Added events for snapshots, vmsnapshots, internalLB operations #11230

Uh oh!

Conversation

harikrishna-patnala commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 22, 2025

Uh oh!

blueorangutan commented Jul 22, 2025

Uh oh!

blueorangutan commented Jul 22, 2025

Uh oh!

harikrishna-patnala commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 25, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

harikrishna-patnala commented Jul 17, 2025 •

edited

Loading

codecov bot commented Jul 17, 2025 •

edited

Loading