Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config #11256
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default value for the configuration 'vm.network.nic.max.secondary.ipaddresses' from 256 to 10 to align with its config description and improve consistency between the default value definition and fallback parsing logic.
- Updates the config enum default value from "256" to "10"
- Modifies NetworkServiceImpl to use the config's default value as fallback instead of hardcoded 10
- Adds database migration scripts to update existing installations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Config.java | Updates MaxNumberOfSecondaryIPsPerNIC default value from "256" to "10" |
| NetworkServiceImpl.java | Changes fallback value in parseInt from hardcoded 10 to config's default value |
| schema-42010to42020.sql | Database migration script to update default and null values |
| schema-42010to42020-cleanup.sql | Empty cleanup script for the migration |
| Upgrade42010to42020.java | Database upgrade handler for version 4.20.1.0 to 4.20.2.0 |
| DatabaseUpgradeChecker.java | Registers the new upgrade handler in the upgrade chain |
|
@blueorangutan package |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11256 +/- ##
============================================
+ Coverage 3.89% 16.74% +12.84%
- Complexity 0 14062 +14062
============================================
Files 417 5724 +5307
Lines 33973 507787 +473814
Branches 6097 61734 +55637
============================================
+ Hits 1324 85027 +83703
- Misses 32491 413282 +380791
- Partials 158 9478 +9320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14292 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
This will need some upgrade testing @sureshanaparti :
|
|
[SF] Trillian test result (tid-13850)
|
|
After a bit of backtalk with @sureshanaparti , we agreed to move this to 4.21 as 4.20.1 -> 4.20.2 -> 4.21 upgrades for this will be tricky and this is only a minor issue. |
07edabe to
4cebdd0
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
…e (and value if not set) to 10 as per the config description and default value in parseInt of the config
4cebdd0 to
74fddd7
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14353 |
|
upgrades tested from 4.19 and 4.20 |
Description
This PR updates the config 'vm.network.nic.max.secondary.ipaddresses' default value (and value if not set) to 10 as per the config description (as per the last relevant commit: 0b956bb) and default value in parseInt of the config (here: 4925b9f).
Fixes #11250
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified the config 'vm.network.nic.max.secondary.ipaddresses' default value & value.
How did you try to break this feature and the system with this change?