Skip to content

java: fix one typo in many files #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

java: fix one typo in many files #11284

wants to merge 1 commit into from

Conversation

jbampton
Copy link
Member

CheckDataStoreStoragePolicyComplainceCommand -> CheckDataStoreStoragePolicyComplianceCommand

isStoragePoolStoragepolicyComplaince -> isStoragePoolStoragepolicyCompliance

Also renamed the file. So the one typo is:

Complaince is changed to Compliance

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@jbampton
java: fix one typo in many files
d1b6fb9 
CheckDataStoreStoragePolicyComplainceCommand -> CheckDataStoreStoragePolicyComplianceCommand

Also renamed the file
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 16.74%. Comparing base (7da5f90) to head (d1b6fb9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...om/cloud/deploy/DeploymentPlanningManagerImpl.java 0.00% 4 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java 0.00% 1 Missing and 1 partial ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 2 Missing ⚠️
.../xenserver/resource/XenServerStorageProcessor.java 0.00% 2 Missing ⚠️
...nserver/resource/Xenserver625StorageProcessor.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 2 Missing ⚠️
.../CheckDataStoreStoragePolicyComplianceCommand.java 0.00% 1 Missing ⚠️
...d/hypervisor/vmware/manager/VmwareManagerImpl.java 0.00% 1 Missing ⚠️
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11284   +/-   ##
=========================================
  Coverage     16.74%   16.74%           
- Complexity    14062    14063    +1     
=========================================
  Files          5724     5724           
  Lines        507785   507785           
  Branches      61733    61733           
=========================================
+ Hits          85038    85039    +1     
+ Misses       413264   413263    -1     
  Partials       9483     9483
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.66% <5.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

I think this fix must go in but it is a risky one as a lot of code changes.
@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14344

sureshanaparti
sureshanaparti approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13887)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 65039 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13887-kvm-ol8.zip
Smoke tests completed. 141 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_zones_metrics Error 0.25 test_metrics_api.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13888)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 69056 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13888-kvm-ubuntu22.zip
Smoke tests completed. 140 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_zones_metrics Error 0.27 test_metrics_api.py
test_01_vpc_site2site_vpn_multiple_options Failure 619.30 test_vpc_vpn.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13890)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 84179 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13890-xcpng82.zip
Smoke tests completed. 138 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 6.27 test_diagnostics.py
test_list_zones_metrics Error 0.22 test_metrics_api.py
test_01_prepare_and_cancel_maintenance Error 0.18 test_ms_maintenance_and_safe_shutdown.py
test_01_deployVMInSharedNetwork Failure 558.32 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13889)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 199827 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13889-vmware-70u3.zip
Smoke tests completed. 133 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_3d_gpu_support Error 303.30 test_deploy_vgpu_enabled_vm.py
test_list_zones_metrics Error 0.21 test_metrics_api.py
test_01_prepare_and_cancel_maintenance Error 0.33 test_ms_maintenance_and_safe_shutdown.py
test_01_deploy_vm_on_specific_host Error 12.65 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 3602.59 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 2.43 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 1.39 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 4.40 test_vm_deployment_planner.py
test_01_migrate_vm_strict_tags_success Error 3608.76 test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure Error 22.41 test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success Error 3608.61 test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure Error 6.10 test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success Error 24.40 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Error 3604.61 test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags Error 27.40 test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags Error 7209.75 test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success Error 3609.59 test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success Error 9.10 test_vm_strict_host_tags.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 3742.25 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Error 1952.42 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 3626.01 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 1830.93 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 1826.92 test_vpc_redundant.py
test_02_VPC_default_routes Error 1824.71 test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn Failure 1814.04 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Error 1814.14 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Failure 3715.74 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Error 3715.91 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Failure 1814.62 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 3613.99 test_vpc_vpn.py
test_01_vpc_site2site_vpn Error 3614.14 test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs Error 1806.97 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 3785.13 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 3785.30 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 1800.96 test_host_maintenance.py

shwstppr
shwstppr approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees
No one assigned
Labels
component:kvm component:simulator component:storage component:vmware component:XenServer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbampton @DaanHoogland @blueorangutan @shwstppr @sureshanaparti
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy