-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix the same typo in 8 Java exception messages #11285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update codespell.txt remove `excetion`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11285 +/- ##
============================================
+ Coverage 3.89% 16.74% +12.85%
- Complexity 0 14066 +14066
============================================
Files 417 5724 +5307
Lines 33973 507787 +473814
Branches 6097 61734 +55637
============================================
+ Hits 1324 85047 +83723
- Misses 32491 413256 +380765
- Partials 158 9484 +9326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14350 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change, but would like to take the chance to also change
- the use of the generic
RuntimeException
and replace it with our own - replace the repetitive message to messages specific to the jobs
@@ -3105,7 +3105,7 @@ public Volume detachVolumeFromVM(DetachVolumeCmd cmmd) { | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous detach volume job", e); |
@@ -3534,7 +3534,7 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) { | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous migrate volume job", e); |
@@ -3876,7 +3876,7 @@ private Snapshot takeSnapshotInternal(Long volumeId, Long policyId, Long snapsho | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous take volume snapshot job", e); |
@@ -4201,7 +4201,7 @@ public String extractVolume(ExtractVolumeCmd cmd) { | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous extract volume job", e); |
@@ -539,7 +539,7 @@ public VMSnapshot createVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiesce | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (java.util.concurrent.ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous create VM snapshot job", e); |
@@ -649,7 +649,7 @@ public boolean deleteVMSnapshot(Long vmSnapshotId) { | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (java.util.concurrent.ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous delete VM snapshot job", e); |
@@ -774,7 +774,7 @@ public UserVm revertToSnapshot(Long vmSnapshotId) throws InsufficientCapacityExc | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (java.util.concurrent.ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous revert to snapshot job", e); |
@@ -1025,7 +1025,7 @@ public boolean deleteAllVMSnapshots(long vmId, VMSnapshot.Type type) { | |||
} catch (InterruptedException e) { | |||
throw new RuntimeException("Operation is interrupted", e); | |||
} catch (java.util.concurrent.ExecutionException e) { | |||
throw new RuntimeException("Execution excetion", e); | |||
throw new RuntimeException("Execution exception", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new RuntimeException("Execution exception", e); | |
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous delete snapshots job", e); |
@weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;
|
Update codespell.txt remove
excetion
Description
This PR fixes a simple typo in the exception messages.
Hoping simple fixes can be merged quickly. Let us move faster 🚀
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?