Skip to content

Fix the same typo in 8 Java exception messages #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbampton
Copy link
Member

Update codespell.txt remove excetion

Description

This PR fixes a simple typo in the exception messages.

Hoping simple fixes can be merged quickly. Let us move faster 🚀

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Update codespell.txt remove `excetion`
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 16.74%. Comparing base (22b753e) to head (8878688).

Files with missing lines Patch % Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 4 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main   #11285       +/-   ##
============================================
+ Coverage     3.89%   16.74%   +12.85%     
- Complexity       0    14066    +14066     
============================================
  Files          417     5724     +5307     
  Lines        33973   507787   +473814     
  Branches      6097    61734    +55637     
============================================
+ Hits          1324    85047    +83723     
- Misses       32491   413256   +380765     
- Partials       158     9484     +9326     
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14350

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change, but would like to take the chance to also change

  1. the use of the generic RuntimeException and replace it with our own
  2. replace the repetitive message to messages specific to the jobs

@@ -3105,7 +3105,7 @@ public Volume detachVolumeFromVM(DetachVolumeCmd cmmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous detach volume job", e);

@@ -3534,7 +3534,7 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous migrate volume job", e);

@@ -3876,7 +3876,7 @@ private Snapshot takeSnapshotInternal(Long volumeId, Long policyId, Long snapsho
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous take volume snapshot job", e);

@@ -4201,7 +4201,7 @@ public String extractVolume(ExtractVolumeCmd cmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous extract volume job", e);

@@ -539,7 +539,7 @@ public VMSnapshot createVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiesce
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous create VM snapshot job", e);

@@ -649,7 +649,7 @@ public boolean deleteVMSnapshot(Long vmSnapshotId) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous delete VM snapshot job", e);

@@ -774,7 +774,7 @@ public UserVm revertToSnapshot(Long vmSnapshotId) throws InsufficientCapacityExc
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous revert to snapshot job", e);

@@ -1025,7 +1025,7 @@ public boolean deleteAllVMSnapshots(long vmId, VMSnapshot.Type type) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
throw new RuntimeException("Execution excetion", e);
throw new RuntimeException("Execution exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Execution exception", e);
throw new CloudRuntimeException("Execution exception getting the outcome of the asynchronous delete snapshots job", e);

@DaanHoogland
Copy link
Contributor

@weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;

I like the change, but would like to take the chance to also change

  1. the use of the generic RuntimeException and replace it with our own
  2. replace the repetitive message to messages specific to the jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy