Update System VM template Guest OS version #11291
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the System VM template Guest OS version from older Debian/Linux versions to Debian GNU/Linux 12 (64-bit) across all hypervisor types. This is a bug fix to ensure system VMs use the correct and updated guest OS configuration.
Key Changes:
- Updated guest OS ID mapping for all hypervisors to use Debian 12 (LINUX_12_ID = 363)
- Added dynamic guest OS lookup functionality to resolve the actual guest OS ID at runtime
- Replaced hardcoded legacy Linux IDs with the new Debian 12 configuration
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
Outdated
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
Outdated
Show resolved
Hide resolved
31185a5 to
f6b506b
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
| put(Hypervisor.HypervisorType.XenServer, OTHER_LINUX_ID); | ||
| put(Hypervisor.HypervisorType.VMware, OTHER_LINUX_ID); |
There was a problem hiding this comment.
I don't think it matters, but historically, we've used Other Linux (64-bits) for the XS and Vmware. https://docs.cloudstack.apache.org/en/4.15.1.0/upgrading/upgrade/upgrade-4.14.html#update-system-vm-templates
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11291 +/- ##
============================================
- Coverage 16.15% 16.15% -0.01%
- Complexity 13272 13274 +2
============================================
Files 5656 5656
Lines 497814 497827 +13
Branches 60380 60381 +1
============================================
Hits 80435 80435
- Misses 408428 408440 +12
- Partials 8951 8952 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14357 |
| public void updateSystemVmTemplateGuestOsId() { | ||
| String systemVmGuestOsName = "Debian GNU/Linux 12 (64-bit)"; | ||
| GuestOSVO guestOS = guestOSDao.findOneByDisplayName(systemVmGuestOsName); | ||
| if (guestOS != null) { | ||
| LOGGER.debug("Updating SystemVM Template Guest OS [{}] id", systemVmGuestOsName); | ||
| SystemVmTemplateRegistration.LINUX_12_ID = Math.toIntExact(guestOS.getId()); | ||
| hypervisorGuestOsMap.put(Hypervisor.HypervisorType.KVM, LINUX_12_ID); | ||
| hypervisorGuestOsMap.put(Hypervisor.HypervisorType.XenServer, LINUX_12_ID); | ||
| hypervisorGuestOsMap.put(Hypervisor.HypervisorType.VMware, LINUX_12_ID); | ||
| hypervisorGuestOsMap.put(Hypervisor.HypervisorType.Hyperv, LINUX_12_ID); | ||
| hypervisorGuestOsMap.put(Hypervisor.HypervisorType.LXC, LINUX_12_ID); | ||
| } | ||
| } |
There was a problem hiding this comment.
is there any way we can detect? this remains a maintenance issue after this change.
Description
This PR updates System VM template Guest OS version, to Debian GNU/Linux 12 (64-bit).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?