Skip to content

Extensions Framework & Orchestrate Anything #9752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 263 commits into
base: main
Choose a base branch
from

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Oct 1, 2024

Description

The Extensions Framework in Apache CloudStack is designed to provide a flexible and standardised mechanism for integrating external systems and custom workflows into CloudStack’s orchestration process. By defining structured hook points during key operations—such as virtual machine deployment, resource preparation, and lifecycle events—the framework allows administrators and developers to extend CloudStack’s behaviour without modifying its core codebase. This design specification outlines the architecture, payload structure, execution flow, and integration guidelines necessary to implement, register, and manage extensions effectively within the CloudStack environment.

For the initial implementation of the Extensions Framework, only Orchestrator-type extensions will be supported. These extensions enable seamless integration of external VM deployment and lifecycle management systems into CloudStack

A design document is made with more details at https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Extensions+Framework+-++Orchestartor+or+External+Deployment+Integration

Documentation PR: apache/cloudstack-documentation#523

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Extensions List:

extensions

Create Extension Form:

create-extension

Extension View:
image

Add Custom Action Form:
add-custom-action

Run Custom Action Form:
run-custom-action

Run Action:
run-custom-action-instance

Built-in Extensions:
image

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

❌ Patch coverage is 44.76840% with 2349 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.00%. Comparing base (217ff27) to head (d673742).

Files with missing lines Patch % Lines
...work/extensions/manager/ExtensionsManagerImpl.java 59.23% 265 Missing and 159 partials ⚠️
...al/provisioner/ExternalPathPayloadProvisioner.java 62.59% 161 Missing and 35 partials ⚠️
...hypervisor/external/resource/ExternalResource.java 9.70% 184 Missing and 2 partials ⚠️
...udstack/agent/manager/ExternalTemplateAdapter.java 21.62% 112 Missing and 4 partials ⚠️
.../external/discoverer/ExternalServerDiscoverer.java 37.10% 96 Missing and 4 partials ⚠️
...loudstack/agent/manager/ExternalServerPlanner.java 0.00% 84 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 52.79% 50 Missing and 26 partials ⚠️
...che/cloudstack/api/response/ExtensionResponse.java 0.00% 73 Missing ⚠️
...ck/api/response/ExtensionCustomActionResponse.java 0.00% 72 Missing ⚠️
...n/java/com/cloud/resource/ResourceManagerImpl.java 0.00% 66 Missing ⚠️
... and 89 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9752      +/-   ##
============================================
+ Coverage     16.76%   17.00%   +0.23%     
- Complexity    14281    14718     +437     
============================================
  Files          5767     5832      +65     
  Lines        512657   517561    +4904     
  Branches      62359    62982     +623     
============================================
+ Hits          85941    87988    +2047     
- Misses       417118   419640    +2522     
- Partials       9598     9933     +335     
Flag Coverage Δ
uitests 3.82% <ø> (-0.04%) ⬇️
unittests 17.95% <44.76%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@apache apache deleted a comment from blueorangutan Oct 1, 2024
@apache apache deleted a comment from blueorangutan Oct 1, 2024
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11530

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harikrishna-patnala , I noticed I had started reviewing this and abandonned it. I was about half way anf will leave you the comments now. I will revisit after 4.20 is out.

@@ -67,6 +70,9 @@ public class UpdateHostCmd extends BaseCmd {
@Parameter(name = ApiConstants.ANNOTATION, type = CommandType.STRING, description = "Add an annotation to this host", since = "4.11", authorized = {RoleType.Admin})
private String annotation;

@Parameter(name = ApiConstants.EXTERNAL_DETAILS, type = CommandType.MAP, description = "Details in key/value pairs using format externaldetails[i].keyname=keyvalue. Example: externaldetails[0].endpoint.url=urlvalue", since = "4.21.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

details instead of external...

@@ -359,9 +362,21 @@ public Map<String, String> getDetails() {
}
}
}

detailsMap.putAll(getExternalDetails());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see? these are just details.

@sureshanaparti sureshanaparti self-assigned this Nov 13, 2024
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11592

@harikrishna-patnala
Copy link
Contributor Author

@DaanHoogland I see many other custom detail parameters in a few other APIs, such as vnfdetails, domaindetails, accountdetails, and a few more.

In this case, I would like to keep this as a separate parameter because these are the only details that are important if the hypervisor type is External. The other parameters are just meant to fit into CloudStack's workflow. The core purpose of this feature is to send these external details to the external provisioner.

Copy link

github-actions bot commented Dec 3, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link

github-actions bot commented Dec 3, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing. Tested HyperV in-built extension, custom actions, configuration detals, different user roles, multiple management servers handling.

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14372

@sureshanaparti
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@abh1sar
Copy link
Collaborator

abh1sar commented Jul 26, 2025

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14385

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

[SF] Trillian test result (tid-13899)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 60274 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9752-t13899-kvm-ubuntu22.zip
Smoke tests completed. 142 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_extension_sync Failure 317.43 test_extension_lifecycle.py
test_09_extension_deploy_vm Error 12.16 test_extension_lifecycle.py
test_09_extension_deploy_vm Error 12.16 test_extension_lifecycle.py
test_list_zones_metrics Error 0.28 test_metrics_api.py
test_02_L2_persistent_network Failure 102.88 test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist Failure 151.52 test_persistent_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13898)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60332 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9752-t13898-kvm-ol8.zip
Smoke tests completed. 144 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_zones_metrics Error 0.22 test_metrics_api.py

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14393

@sureshanaparti
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13901)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 83542 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9752-t13901-xcpng82.zip
Smoke tests completed. 143 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_zones_metrics Error 0.22 test_metrics_api.py
test_01_vpn_usage Error 1.11 test_usage.py

@sureshanaparti
Copy link
Contributor

@blueorangutan test ubuntu24 kvm-ubuntu24

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13904)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 64745 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9752-t13904-kvm-ubuntu22.zip
Smoke tests completed. 144 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_zones_metrics Error 0.20 test_metrics_api.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13915)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55565 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9752-t13915-kvm-ol8.zip
Smoke tests completed. 145 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy