Skip to content

Add a github action message after format issue found #15379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

wcy666103
Copy link
Contributor

@wcy666103 wcy666103 commented May 12, 2025

What is the purpose of the change?

Currently, there are a lot of less familiar contributors who experience action failures when submitting PRS. One of the most common failures is the 'Check if code needs formatting' failure, such as:

image

#15378
#15262

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (d6b11cf) to head (3473a22).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15379      +/-   ##
============================================
+ Coverage     60.73%   60.78%   +0.05%     
+ Complexity    10920    10917       -3     
============================================
  Files          1886     1886              
  Lines         86162    86162              
  Branches      12913    12913              
============================================
+ Hits          52328    52375      +47     
+ Misses        28374    28326      -48     
- Partials       5460     5461       +1     
Flag Coverage Δ
integration-tests 33.12% <ø> (+<0.01%) ⬆️
samples-tests 29.40% <ø> (+0.03%) ⬆️
unit-tests 58.94% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw
Copy link
Contributor

zrlw commented May 14, 2025

pls see the summary of github action.
b866f175ceea88a4e381063e1ba6c1f4

@wcy666103
Copy link
Contributor Author

pls see the summary of github action. b866f175ceea88a4e381063e1ba6c1f4

It's just that most people with this problem don't choose to read the Summary.

@oxsean oxsean merged commit e845fe4 into apache:3.3 May 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy