Skip to content

optee-utee: support setting capacity of shared buffer of LoadablePlugin #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

optee-utee: support setting capacity of shared buffer of LoadablePlugin #154

merged 1 commit into from
Dec 12, 2024

Conversation

ivila
Copy link
Contributor

@ivila ivila commented Dec 6, 2024

  1. introduce a Command struct for flexible use
  2. allow developers settings capacity of shared buffer when invoking
    command

@ivila
Copy link
Contributor Author

ivila commented Dec 6, 2024

Found some error during CI, I am trying to reproduce on my machine (I think in some platform the c_char was treated as i8 instead of u8)

@ivila
Copy link
Contributor Author

ivila commented Dec 6, 2024

Pipeline fixed: https://github.com/ivila/incubator-teaclave-trustzone-sdk/actions/runs/12194856005/job/34019402495

@ivila
Copy link
Contributor Author

ivila commented Dec 6, 2024

This PR relates to #153

DemesneGH
DemesneGH reviewed Dec 6, 2024
View reviewed changes
@ivila
Copy link
Contributor Author

ivila commented Dec 6, 2024

Copy, I will update it later(before next tuesday)

@ivila ivila requested a review from DemesneGH December 7, 2024 01:16
@DemesneGH
Copy link
Contributor

Reviewed-by: Yuan Zhuang <yuanz@apache.org>

@ivila
Copy link
Contributor Author

ivila commented Dec 7, 2024

Reviewed-by: Yuan Zhuang <yuanz@apache.org>

I already add it in my first commit😈

mssun
mssun approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@mssun mssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DemesneGH
Copy link
Contributor

@b49020 What do you think?

@b49020
Copy link
Contributor

b49020 commented Dec 11, 2024

Acked-by: Sumit Garg <sumit.garg@linaro.org>

@ivila
optee-utee: support setting capacity of shared buffer of LoadablePlugin
1915529 
1) introduce a Command struct for flexible use
2) allow developers settings capacity of shared buffer when invoking
   command

Signed-off-by: ivila <390810839@qq.com>
Reviewed-by: Yuan Zhuang <yuanz@apache.org>
Acked-by: Sumit Garg <sumit.garg@linaro.org>
@ivila
Copy link
Contributor Author

ivila commented Dec 11, 2024

Acked-by: Sumit Garg <sumit.garg@linaro.org>

@b49020 done, thanks.

@DemesneGH DemesneGH merged commit 8bb315f into apache:main Dec 12, 2024
7 checks passed
@DemesneGH DemesneGH mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssun mssun mssun approved these changes

@DemesneGH DemesneGH DemesneGH approved these changes

@AI-Memory AI-Memory AI-Memory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivila @DemesneGH @b49020 @mssun @AI-Memory
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy