Show original and changed linefeed in diff view #8645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
reviewed
Jul 10, 2025
ide/diff/src/org/netbeans/modules/diff/builtin/visualizer/editable/EditableDiffView.java
Outdated
Show resolved
Hide resolved
097cde8 to
273527e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior, when the linefeed changes, you just see, that the file was modified but you dunno why. This PR adds the original and the changed linefeed.
I used GridLayout for the header because I couldn't handle adding the exact position what it is now. But this changes the layout a bit, You can see it in the before and after image.
Before
After
So I'm not that good at design JSwing UIs with correct position etc. So please have a look and if you find a better solution, please lemme know.
^Add meaningful description above
Click to collapse/expand PR instructions
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)