Skip to content

refactor!: Replace HttpxHttpClient with ImpitHttpClient as default HTTP client #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

refactor!: Replace HttpxHttpClient with ImpitHttpClient as default HTTP client #1307

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
624a152
change httpx to impit like main client
Mantisus Jul 15, 2025
7b523e0
add impit for cli
Mantisus Jul 15, 2025
ecfaf00
fix cli tests
Mantisus Jul 15, 2025
279edb5
resolve
Mantisus Jul 18, 2025
fbd03c4
remove extra example
Mantisus Jul 18, 2025
ee050a6
resolve
Mantisus Jul 21, 2025
d112594
fix types
Mantisus Jul 21, 2025
0f13c60
update impit version
Mantisus Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix cli tests
  • Loading branch information
@Mantisus
Mantisus committed Jul 15, 2025
commit ecfaf004fa032c9d2b220d84bf7ca5eebb380d4b
16 changes: 8 additions & 8 deletions tests/unit/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_create_interactive(mock_cookiecutter: Mock, monkeypatch: pytest.MonkeyP
'project_name': 'my_project',
'package_manager': 'poetry',
'crawler_type': 'beautifulsoup',
'http_client': 'httpx',
'http_client': 'impit',
'enable_apify_integration': False,
'start_url': 'https://crawlee.dev',
'install_project': True,
Expand Down Expand Up @@ -79,7 +79,7 @@ def test_create_interactive_non_default_template(mock_cookiecutter: Mock, monkey
'project_name': 'my_project',
'package_manager': 'poetry',
'crawler_type': 'parsel',
'http_client': 'httpx',
'http_client': 'impit',
'enable_apify_integration': False,
'start_url': 'https://crawlee.dev',
'install_project': True,
Expand All @@ -96,7 +96,7 @@ def test_create_non_interactive(mock_cookiecutter: Mock) -> None:
'--crawler-type',
'playwright',
'--http-client',
'curl-impersonate',
'httpx',
'--package-manager',
'pip',
'--start-url',
Expand All @@ -113,7 +113,7 @@ def test_create_non_interactive(mock_cookiecutter: Mock) -> None:
'project_name': 'my_project',
'package_manager': 'pip',
'crawler_type': 'playwright',
'http_client': 'curl-impersonate',
'http_client': 'httpx',
'start_url': 'https://yr.no',
'enable_apify_integration': False,
'install_project': False,
Expand Down Expand Up @@ -144,7 +144,7 @@ def test_create_existing_folder(
'--crawler-type',
'playwright',
'--http-client',
'curl-impersonate',
'httpx',
'--package-manager',
'pip',
'--start-url',
Expand All @@ -162,7 +162,7 @@ def test_create_existing_folder(
'project_name': 'my_project',
'package_manager': 'pip',
'crawler_type': 'playwright',
'http_client': 'curl-impersonate',
'http_client': 'httpx',
'start_url': 'https://yr.no',
'enable_apify_integration': False,
'install_project': True,
Expand Down Expand Up @@ -202,7 +202,7 @@ def test_create_existing_folder_interactive(
'project_name': 'my_project',
'package_manager': 'poetry',
'crawler_type': 'playwright',
'http_client': 'httpx',
'http_client': 'impit',
'start_url': 'https://crawlee.dev',
'enable_apify_integration': False,
'install_project': True,
Expand Down Expand Up @@ -245,7 +245,7 @@ def test_create_existing_folder_interactive_multiple_attempts(
'project_name': 'my_project',
'package_manager': 'poetry',
'crawler_type': 'playwright',
'http_client': 'httpx',
'http_client': 'impit',
'start_url': 'https://crawlee.dev',
'enable_apify_integration': False,
'install_project': True,
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy