Skip to content

Improve scheduled executions #8412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 12, 2024
Merged

Improve scheduled executions #8412

merged 17 commits into from
Aug 12, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jul 18, 2024 •
edited
Loading

  • implemented delayed execution for scheduled functions using coroutines
  • modified the enqueue logic to trigger functions at their scheduled time instead of immediately
  • updated tests to verify accurate execution timing

@loks0n loks0n changed the base branch from main to 1.6.x July 18, 2024 12:04
byawitz
byawitz approved these changes Jul 18, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,710
  • Requests with 200 status code: 307,827
  • P99 latency: 0.079155881

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,710 2,158
200 307,827 388,569
P99 0.079155881 0.073684807

@loks0n loks0n requested a review from Meldiron August 7, 2024 16:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

✨ Benchmark results

  • Requests per second: 1,776
  • Requests with 200 status code: 319,800
  • P99 latency: 0.079552716

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,776 2,247
200 319,800 404,469
P99 0.079552716 0.07095402

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

✨ Benchmark results

  • Requests per second: 1,661
  • Requests with 200 status code: 298,988
  • P99 latency: 0.079449971

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,661 2,071
200 298,988 372,897
P99 0.079449971 0.073811337

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

✨ Benchmark results

  • Requests per second: 1,764
  • Requests with 200 status code: 317,626
  • P99 latency: 0.076641991

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,764 2,233
200 317,626 401,993
P99 0.076641991 0.073244197

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

✨ Benchmark results

  • Requests per second: 1,680
  • Requests with 200 status code: 302,497
  • P99 latency: 0.079970675

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,680 2,136
200 302,497 384,555
P99 0.079970675 0.074837676

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

✨ Benchmark results

  • Requests per second: 1,562
  • Requests with 200 status code: 281,238
  • P99 latency: 0.084153132

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,562 1,958
200 281,238 352,505
P99 0.084153132 0.077843264

@loks0n loks0n added the product / functions Fixes and upgrades for the Appwrite Functions. label Aug 12, 2024
@christyjacob4 christyjacob4 merged commit ad43e1c into 1.6.x Aug 12, 2024
23 of 24 checks passed
@christyjacob4 christyjacob4 deleted the feat-schedule-execution-improvements branch August 12, 2024 16:00
@stnguyen90 stnguyen90 changed the title feat: schedule execution improvements Improve scheduled executions Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byawitz byawitz byawitz approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees
No one assigned
Labels
product / functions Fixes and upgrades for the Appwrite Functions.
Projects
1.6 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loks0n @byawitz @christyjacob4
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy