Skip to content

Update create execution return type #8542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 16, 2024
Merged

Update create execution return type #8542

merged 7 commits into from
Aug 16, 2024

Conversation

byawitz
Copy link
Member

@byawitz byawitz commented Aug 14, 2024

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,655
  • Requests with 200 status code: 297,930
  • P99 latency: 0.081943992

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,655 2,113
200 297,930 380,316
P99 0.081943992 0.076085367

Meldiron
Meldiron approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. we can merge if this is needed for sdk-generator to work properly

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

byawitz added 3 commits August 16, 2024 16:19
@byawitz
Merge remote-tracking branch 'origin/refactor-changing-function-sdk-t…
db359e5 
…ypes' into refactor-changing-function-sdk-types
@byawitz
Merge branch 'refs/heads/1.6.x' into refactor-changing-function-sdk-t…
2de3803 
…ypes

# Conflicts:
#	app/config/specs/open-api3-latest-client.json
#	app/config/specs/open-api3-latest-console.json
#	app/config/specs/open-api3-latest-server.json
#	app/config/specs/swagger2-latest-client.json
#	app/config/specs/swagger2-latest-console.json
#	app/config/specs/swagger2-latest-server.json
@byawitz
chore: matching latest specs
f60992e
@christyjacob4 christyjacob4 merged commit 94070fd into 1.6.x Aug 16, 2024
6 checks passed
@christyjacob4 christyjacob4 deleted the refactor-changing-function-sdk-types branch August 16, 2024 20:27
@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

@stnguyen90 stnguyen90 changed the title Refactor changing function sdk types Update create execution return type Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@vermakhushboo vermakhushboo vermakhushboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byawitz @Meldiron @christyjacob4 @vermakhushboo
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy