Skip to content

Support renaming attributes #8544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Support renaming attributes #8544

merged 12 commits into from
Sep 5, 2024

Conversation

PineappleIOnic
Copy link
Contributor

What does this PR do?

This PR implements the ability to rename attributes in the API; it also adds tests for this, including for renaming relationship attributes to ensure they do not break when doing this.

Test Plan

Tests have been added for both normal attributes and relationships (all types) to confirm nothing breaks.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Aug 16, 2024

✨ Benchmark results

  • Requests per second: 1,640
  • Requests with 200 status code: 295,195
  • P99 latency: 0.082494649

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,640 1,705
200 295,195 306,920
P99 0.082494649 0.082118472

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will keep the PR open until the console side is sorted in case we need to change target branch 👍

# Conflicts:
#	app/config/specs/open-api3-latest-console.json
#	app/config/specs/open-api3-latest-server.json
#	app/config/specs/swagger2-1.6.X-client.json
#	app/config/specs/swagger2-1.6.X-console.json
#	app/config/specs/swagger2-latest-console.json
#	app/config/specs/swagger2-latest-server.json
#	app/controllers/shared/api.php
#	app/realtime.php
#	composer.lock
#	src/Appwrite/Platform/Workers/Deletes.php
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

# Conflicts:
#	app/config/specs/open-api3-latest-console.json
#	app/config/specs/open-api3-latest-server.json
#	app/config/specs/swagger2-1.6.x-console.json
#	app/config/specs/swagger2-latest-console.json
#	app/config/specs/swagger2-latest-server.json
#	composer.lock
@abnegate abnegate changed the base branch from 1.6.x to 1.6.1 September 4, 2024 09:19
Copy link

github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

…utes

# Conflicts:
#	app/config/specs/open-api3-latest-console.json
#	app/config/specs/open-api3-latest-server.json
#	app/config/specs/swagger2-latest-console.json
#	app/config/specs/swagger2-latest-server.json
#	app/controllers/api/databases.php
Copy link

github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

@abnegate abnegate merged commit 583bb7d into 1.6.1 Sep 5, 2024
23 checks passed
@abnegate abnegate deleted the feat-renaming-attributes branch September 5, 2024 09:48
@stnguyen90 stnguyen90 changed the title Implement Renaming Attributes in the API Support renaming attributes Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy