Skip to content

Fix scheduled executions data #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2024
Merged

Fix scheduled executions data #8639

merged 6 commits into from
Sep 17, 2024

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Sep 7, 2024

What does this PR do?

Path, method, body and header are missing in scheduled executions.

They also are never tested properly

User ID and JWT also likely doesn't work well, and also isn't tested

Test Plan

  • update & add tests

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

ItzNotABug
ItzNotABug reviewed Sep 7, 2024
View reviewed changes
Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, rest LGTM.

Meldiron
Meldiron commented Sep 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,654
  • Requests with 200 status code: 297,768
  • P99 latency: 0.082116776

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,654 1,719
200 297,768 309,425
P99 0.082116776 0.083908979

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
pyc 3.11.9-r0 CVE-2024-6232 HIGH
pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3 3.11.9-r0 CVE-2024-6232 HIGH
python3 3.11.9-r0 CVE-2024-7592 HIGH
python3-pyc 3.11.9-r0 CVE-2024-6232 HIGH
python3-pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-6232 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-7592 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
pyc 3.11.9-r0 CVE-2024-6232 HIGH
pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3 3.11.9-r0 CVE-2024-6232 HIGH
python3 3.11.9-r0 CVE-2024-7592 HIGH
python3-pyc 3.11.9-r0 CVE-2024-6232 HIGH
python3-pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-6232 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-7592 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@christyjacob4 christyjacob4 merged commit af126a2 into 1.6.x Sep 17, 2024
25 checks passed
@christyjacob4 christyjacob4 deleted the fix-scheduled-executions branch September 17, 2024 21:40
@stnguyen90 stnguyen90 changed the title Fix: scheduled executions data Fix scheduled executions data Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzNotABug ItzNotABug ItzNotABug approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @ItzNotABug @christyjacob4
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy