Skip to content

fix: flaky functions tests #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Oct 3, 2024
Merged

fix: flaky functions tests #8682

merged 42 commits into from
Oct 3, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Sep 18, 2024

  • Helper methods for test setup: setupFunction, setupDeployment
  • Uses assertEventually for polling async actions
  • Split long running schedule related tests to seperate runner: FunctionScheduleTest.php

Reduces Functions test times from 18 minutes to 8 minutes

@loks0n loks0n changed the base branch from main to 1.6.x September 18, 2024 13:33
Copy link

github-actions bot commented Sep 18, 2024

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Sep 18, 2024

✨ Benchmark results

  • Requests per second: 1,056
  • Requests with 200 status code: 190,175
  • P99 latency: 0.096466685

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,056 1,610
200 190,175 289,899
P99 0.096466685 0.071634088

@loks0n loks0n changed the base branch from 1.6.x to main September 25, 2024 08:41
@loks0n loks0n changed the base branch from main to 1.6.x October 2, 2024 10:55
@Meldiron Meldiron merged commit a6ceda3 into 1.6.x Oct 3, 2024
26 checks passed
@Meldiron Meldiron deleted the fix-flaky-tests branch October 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy