Add domain and force HTTPS env vars to mail worker #8722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security Scan Results for PRDocker Image Scan Results🎉 No vulnerabilities found! Source Code Scan Results🎉 No vulnerabilities found! |
byawitz
reviewed
Sep 25, 2024
✨ Benchmark results
⚡ Benchmark Comparison
|
The worker uses the env vars so we need to include it in the compose file to ensure the variable passes into the container.
6b8961f to
31e03bf
Compare
byawitz
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The worker uses the env vars
appwrite/src/Appwrite/Platform/Workers/Mails.php
Lines 68 to 69 in fdd39a2
So we need to include it in the compose file to ensure the variable passes into the container.
Test Plan
None
Related PRs and Issues
None
Checklist