Skip to content

fix: missing protocol #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: missing protocol #8749

merged 1 commit into from
Oct 3, 2024

Conversation

byawitz
Copy link
Member

@byawitz byawitz commented Oct 2, 2024

What does this PR do?

Adding missing ssl protocol
For #8438

Test Plan

Manually

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@byawitz byawitz requested a review from stnguyen90 October 2, 2024 17:28
Copy link

github-actions bot commented Oct 2, 2024

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Oct 2, 2024

✨ Benchmark results

  • Requests per second: 1,111
  • Requests with 200 status code: 200,112
  • P99 latency: 0.091542674

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,111 1,666
200 200,112 299,939
P99 0.091542674 0.070158841

@stnguyen90 stnguyen90 merged commit 490d8d4 into 1.6.x Oct 3, 2024
25 checks passed
@stnguyen90 stnguyen90 deleted the fix-missing-protocol branch October 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy