Skip to content

Throw exception for error #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

vermakhushboo
Copy link
Member

What does this PR do?

Throw 409 exception if subdomain already exists, otherwise return 204 status code.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

✨ Benchmark results

  • Requests per second: 1,157
  • Requests with 200 status code: 208,223
  • P99 latency: 0.091728958

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,157 2,040
200 208,223 367,329
P99 0.091728958 0.077983994

@TorstenDittmann TorstenDittmann merged commit b7f519f into feat-sites Oct 28, 2024
23 of 24 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-check-domain-availability branch October 28, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy