Delete rules when site or deployment is deleted #8939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Benchmark results
⚡ Benchmark Comparison
|
Meldiron
reviewed
Nov 8, 2024
Meldiron
reviewed
Nov 8, 2024
Meldiron
reviewed
Nov 8, 2024
| } | ||
|
|
||
| /** | ||
| * @depends testCreateSite |
There was a problem hiding this comment.
Lets rewrite tests in this file to have no dependencies.
If you need to list, or get, or delete, inside the test you can make new site.
this way we prevent need to use @Depends
There was a problem hiding this comment.
In that case, we'd also need to delete the resources we create in each test at the end of it so that it doesn't cause conflicts with other tests.
For example, while testing listSites, if I am creating sites for it inside the test itself, it should not list sites from other tests. Do you agree each test should also perform cleanup then?
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
christyjacob4
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Delete rules, deployments, builds, variables etc when deleting a site.
Delete rule when deleting a deployment.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist