Fix users create session secret #9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Include at least 1 factor because the minumum number of factors required when mfa is disabled is 1. 2. Purge the cached user document to ensure the new session is included in subsequent requests for the user. 3. Fix the encoding of the secret to match other parts of the codebase.
2 tasks
✨ Benchmark results
⚡ Benchmark Comparison
|
loks0n
approved these changes
Nov 22, 2024
loks0n
reviewed
Nov 22, 2024
| $session | ||
| ->setAttribute('secret', $secret) |
There was a problem hiding this comment.
We have to document this right, it's sort of breaking? Some people could be relying on it
There was a problem hiding this comment.
I don't think anyone is using it because it doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
required when mfa is disabled is 1.
in subsequent requests for the user.
Fixes #8569
Test Plan
Updated test case
Related PRs and Issues
Checklist